From 45630b2813fe6aa57ef81d6dc03b5269c8894a9d Mon Sep 17 00:00:00 2001
From: qvalentin <valentin.theodor@web.de>
Date: Fri, 13 May 2022 20:01:14 +0200
Subject: [PATCH] found a bug, this is why we write tests

---
 .../main/java/persistence/GenericCSVDAO.java  |  2 +-
 .../java/persistence/GenericCSVDAOTest.java   | 99 ++++++++-----------
 2 files changed, 44 insertions(+), 57 deletions(-)

diff --git a/0-Plugin/src/main/java/persistence/GenericCSVDAO.java b/0-Plugin/src/main/java/persistence/GenericCSVDAO.java
index 6c02bfd..e717727 100644
--- a/0-Plugin/src/main/java/persistence/GenericCSVDAO.java
+++ b/0-Plugin/src/main/java/persistence/GenericCSVDAO.java
@@ -61,7 +61,7 @@ public class GenericCSVDAO<T extends CSVSerializable> implements GenericDAO<T> {
 
 	public void removeAll() {
 
-		try (BufferedWriter bufferedWriter = new BufferedWriter(new FileWriter(this.file, true))) {
+		try (BufferedWriter bufferedWriter = new BufferedWriter(new FileWriter(this.file, false))) {
 			bufferedWriter.write("");
 		}
 		catch (IOException e) {
diff --git a/0-Plugin/src/test/java/persistence/GenericCSVDAOTest.java b/0-Plugin/src/test/java/persistence/GenericCSVDAOTest.java
index ad99a63..1f1756d 100644
--- a/0-Plugin/src/test/java/persistence/GenericCSVDAOTest.java
+++ b/0-Plugin/src/test/java/persistence/GenericCSVDAOTest.java
@@ -1,79 +1,66 @@
 package persistence;
 
-import org.junit.Before;
-import org.junit.BeforeClass;
-import org.junit.Test;
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
 import persistence.category.CategoryEntity;
 
 import java.io.File;
 import java.io.IOException;
 
 import static org.junit.Assert.assertEquals;
-import static org.junit.jupiter.api.Assertions.*;
 
 class GenericCSVDAOTest {
 
-    GenericCSVDAO<CategoryEntity> sut;
+	GenericCSVDAO<CategoryEntity> sut;
+	File file = new File("test.csv");
 
-    public void beforeEachDirty() throws IOException {
-        File file = new File("test.csv");
+	@BeforeEach
+	public void beforeEach() throws IOException {
 
-        if (file.exists()){
-            file.delete();
-        }
-        file.createNewFile();
+		if (file.exists()) {
+			file.delete();
+		}
+		file.createNewFile();
 
-        this.sut = new GenericCSVDAO<CategoryEntity>(file,CategoryEntity::new);
+		this.sut = new GenericCSVDAO<>(file, CategoryEntity::new);
+	}
 
+	@AfterEach
+	void afterEach() {
+		file.delete();
+	}
 
-    }
+	@Test
+	public void addWorks() throws IOException {
+		assertEquals(0, sut.getALl().size());
 
-    @Test
-    public void addWorks() throws IOException {
+		var entityToAdd = new CategoryEntity("categoryName", 99);
+		sut.add(entityToAdd);
+		var foundEntity = sut.getALl().stream().findFirst().orElseThrow();
 
-        beforeEachDirty();
+		assertEquals(entityToAdd, foundEntity);
+	}
 
+	@Test
+	public void removeWorks() throws IOException {
+		var entityToAdd = new CategoryEntity("categoryName", 99);
+		sut.add(entityToAdd);
 
-        assertEquals(0, sut.getALl().size());
+		sut.remove(entityToAdd);
 
-        var entityToAdd = new CategoryEntity("categoryName",99);
-        sut.add(entityToAdd);
-        var foundEntity = sut.getALl().stream().findFirst().orElseThrow();
+		assertEquals(0, sut.getALl().size());
+	}
 
-        assertEquals(entityToAdd,foundEntity);
+	@Test
+	public void removeAllWorks() throws IOException {
+		var entityToAdd1 = new CategoryEntity("categoryName1", 101);
+		sut.add(entityToAdd1);
+		var entityToAdd2 = new CategoryEntity("categoryName2", 102);
+		sut.add(entityToAdd2);
+		assertEquals(2, sut.getALl().size());
+		sut.removeAll();
 
-
-
-
-    }
-
-    @Test
-    public void removeWorks() throws IOException {
-
-        beforeEachDirty();
-
-
-        var entityToAdd = new CategoryEntity("categoryName",99);
-        sut.add(entityToAdd);
-
-        sut.remove(entityToAdd);
-
-        assertEquals(0, sut.getALl().size());
-    }
-
-    @Test
-    public void removeAllWorks() throws IOException {
-
-        beforeEachDirty();
-
-
-        var entityToAdd1 = new CategoryEntity("categoryName1",101);
-        sut.add(entityToAdd1);
-        var entityToAdd2 = new CategoryEntity("categoryName2",102);
-        sut.add(entityToAdd2);
-        assertEquals(2, sut.getALl().size());
-        sut.removeAll();
-
-        assertEquals(0, sut.getALl().size());
-    }
-}
\ No newline at end of file
+		assertEquals(0, sut.getALl().size());
+	}
+}